Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: set -Wextra-semi-stmt for clang with --enable-debug #6378

Closed
wants to merge 2 commits into from
Closed

configure: set -Wextra-semi-stmt for clang with --enable-debug #6378

wants to merge 2 commits into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Dec 26, 2020

To have it properly complain on empty statements with no effect.

Ref: #6376
@bagder bagder added the build label Dec 26, 2020
bagder added a commit that referenced this pull request Dec 26, 2020
@bagder
configure: set -Wextra-semi-stmt for clang with --enable-debug
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
0f863aa 
To have it properly complain on empty statements with no effect.

Ref: #6376
Closes #6378
@bagder bagder force-pushed the bagder/clang-extra-semi-stmt branch from 899b4fa to 0f863aa Dec 26, 2020
bagder added 2 commits Dec 26, 2020
@bagder
configure: set -Wextra-semi-stmt for clang with --enable-debug
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
52b0f9b 
To have it properly complain on empty statements with no effect.

Ref: #6376
Closes #6378
@bagder
tests/unit: fix empty statements with no effect
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
b12cf55 
... by making macros use "do {} while(0)"
@bagder bagder force-pushed the bagder/clang-extra-semi-stmt branch from 0f863aa to b12cf55 Dec 29, 2020
@bagder bagder closed this in 26e4661 Dec 29, 2020
@olafhering
Copy link
Contributor

@olafhering olafhering commented Dec 30, 2020

This causes CI errors in MR, not sure if these errors are regressions.
@bagder bagder deleted the bagder/clang-extra-semi-stmt branch Dec 30, 2020
@bagder
Copy link
Member Author

@bagder bagder commented Dec 30, 2020

MR? You mean pull request? If so which? If you rebase on master there should be no such warnings, surely?
@olafhering
Copy link
Contributor

@olafhering olafhering commented Dec 30, 2020

There are a few failures in #6392
Some of them indicate "issues with semicolon", but I did not investigate them.
@bagder
Copy link
Member Author

@bagder bagder commented Dec 30, 2020

Thanks, I noticed! I don't know how I missed them before but I think I've fixed then now...
@olafhering
Copy link
Contributor

@olafhering olafhering commented Dec 30, 2020

I rebased to a6d20b8, lets see how it goes.
@olafhering
Copy link
Contributor

@olafhering olafhering commented Dec 30, 2020

Thanks, appears to work. There are apparently some unrelated runtime errors left.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bagder @olafhering