configure: set -Wextra-semi-stmt for clang with --enable-debug#6378
Closed
bagder wants to merge 2 commits into
Closed
configure: set -Wextra-semi-stmt for clang with --enable-debug#6378bagder wants to merge 2 commits into
bagder wants to merge 2 commits into
Conversation
bagder
force-pushed
the
bagder/clang-extra-semi-stmt
branch
from
899b4fa to
0f863aa
Compare
... by making macros use "do {} while(0)"
bagder
force-pushed
the
bagder/clang-extra-semi-stmt
branch
from
0f863aa to
b12cf55
Compare
Contributor
|
This causes CI errors in MR, not sure if these errors are regressions. |
Member
Author
|
MR? You mean pull request? If so which? If you rebase on master there should be no such warnings, surely? |
Contributor
|
There are a few failures in #6392 |
Member
Author
|
Thanks, I noticed! I don't know how I missed them before but I think I've fixed then now... |
Contributor
|
I rebased to a6d20b8, lets see how it goes. |
Contributor
|
Thanks, appears to work. There are apparently some unrelated runtime errors left. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To have it properly complain on empty statements with no effect.
Ref: #6376