New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: fix CONNECT_ONLY with Negotiate authentication #655

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@MarcelRaad
Member

MarcelRaad commented Feb 15, 2016

Since 79b9d5f, connections were closed immediately before the libcurl user had a chance to extract the socket if Negotiate authentication was used. If CURLOPT_CONNECT_ONLY is set, it is the user's responsibility to decide when to close the connection.

This pull request is the same as #520, but without the HTTP status code check.

http: fix CONNECT_ONLY with Negotiate authentication
CONNECT_ONLY connections were closed immediately before the user had a chance
to extract the socket when the proxy required Negotiate authentication.
@frenche

This comment has been minimized.

Show comment
Hide comment
@frenche

frenche Apr 26, 2016

Contributor

As mention over #520 this look OK to me.

Contributor

frenche commented Apr 26, 2016

As mention over #520 this look OK to me.

@sithglan

This comment has been minimized.

Show comment
Hide comment
@sithglan

sithglan Apr 26, 2016

Contributor

I hit this regression as well. Please apply.

Contributor

sithglan commented Apr 26, 2016

I hit this regression as well. Please apply.

@bagder bagder closed this in c2b3f26 Apr 26, 2016

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Apr 26, 2016

Member

Thanks everyone for your help and contributions!

Member

bagder commented Apr 26, 2016

Thanks everyone for your help and contributions!

@MarcelRaad MarcelRaad deleted the MarcelRaad:connect_only_negotiate branch Apr 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment