Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign uphttp: fix CONNECT_ONLY with Negotiate authentication #655
Conversation
MarcelRaad
referenced this pull request
Feb 15, 2016
Closed
http: fix CONNECT_ONLY with Negotiate authentication #520
This comment has been minimized.
This comment has been minimized.
|
As mention over #520 this look OK to me. |
This comment has been minimized.
This comment has been minimized.
|
I hit this regression as well. Please apply. |
bagder
closed this
in
c2b3f26
Apr 26, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks everyone for your help and contributions! |
MarcelRaad
deleted the
MarcelRaad:connect_only_negotiate
branch
Apr 27, 2016
lock
bot
locked as resolved and limited conversation to collaborators
Jan 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MarcelRaad commentedFeb 15, 2016
Since 79b9d5f, connections were closed immediately before the libcurl user had a chance to extract the socket if Negotiate authentication was used. If CURLOPT_CONNECT_ONLY is set, it is the user's responsibility to decide when to close the connection.
This pull request is the same as #520, but without the HTTP status code check.