http: fix CONNECT_ONLY with Negotiate authentication#655
Closed
MarcelRaad wants to merge 1 commit intocurl:masterfrom
Closed
http: fix CONNECT_ONLY with Negotiate authentication#655MarcelRaad wants to merge 1 commit intocurl:masterfrom
MarcelRaad wants to merge 1 commit intocurl:masterfrom
Conversation
CONNECT_ONLY connections were closed immediately before the user had a chance to extract the socket when the proxy required Negotiate authentication.
Contributor
|
As mention over #520 this look OK to me. |
Contributor
|
I hit this regression as well. Please apply. |
Member
|
Thanks everyone for your help and contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 79b9d5f, connections were closed immediately before the libcurl user had a chance to extract the socket if Negotiate authentication was used. If CURLOPT_CONNECT_ONLY is set, it is the user's responsibility to decide when to close the connection.
This pull request is the same as #520, but without the HTTP status code check.