Skip to content

CI test PR#6756

Closed
jay wants to merge 4 commits into
masterfrom
test-ci
Closed

CI test PR#6756
jay wants to merge 4 commits into
masterfrom
test-ci

Conversation

@jay
Copy link
Copy Markdown
Member

@jay jay commented Mar 17, 2021

A floating PR for collaborators to debug CI related test failures. Force push to upstream/test-ci.

git push --set-upstream upstream test-ci

@ghost
Copy link
Copy Markdown

ghost commented Mar 17, 2021

DeepCode's analysis on #133321 found:

  • ⚠️ 1 warning 👇

Top issues

Description Example fixes
The result of fopen, which may return null flows to the third argument of fprintf. This could result in undefined behavior. Consider adding a check for nullness. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@bagder
Copy link
Copy Markdown
Member

bagder commented Mar 17, 2021

Excellent test @jay!

What puzzles me is that it looks like curl finds CURL_HOME set and uses that, even though the test is supposed to clear that... ?

@jay
Copy link
Copy Markdown
Member Author

jay commented Mar 17, 2021

I'm replying in the issue to discourage discussion in this PR since it's meant to be a generic one we can reuse

nevermind that whatever works

@jay jay force-pushed the test-ci branch 2 times, most recently from a778f60 to 7b7f0fe Compare March 17, 2021 21:03
@bagder
Copy link
Copy Markdown
Member

bagder commented Apr 14, 2021

This hasn't been needed or used now for a month, closing.

@bagder bagder closed this Apr 14, 2021
@bagder bagder deleted the test-ci branch July 30, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration tests

Development

Successfully merging this pull request may close these issues.

2 participants