quiche: fix upload for bigger content-length#8421
Closed
jpmenil wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
ghedo
reviewed
Feb 10, 2022
Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
bagder
reviewed
Feb 10, 2022
Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
|
Looks good! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uploading files, we can hit the underlying stream capacity, which in this case will return QUICHE_H3_ERR_DONE (-1), and result in a failure to send data.
Let fix this by handling this return code.
Signed-off-by: Jean-Philippe Menil jpmenil@gmail.com