Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quiche: fix upload for bigger content-length #8421

Closed
wants to merge 3 commits into from

Conversation

jpmenil
Copy link
Contributor

@jpmenil jpmenil commented Feb 9, 2022

When uploading files, we can hit the underlying stream capacity, which in this case will return QUICHE_H3_ERR_DONE (-1), and result in a failure to send data.

Let fix this by handling this return code.

Signed-off-by: Jean-Philippe Menil jpmenil@gmail.com

Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
@bagder bagder requested a review from ghedo Feb 9, 2022
@bagder bagder added the HTTP/3 label Feb 9, 2022
lib/vquic/quiche.c Outdated Show resolved Hide resolved
Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
lib/vquic/quiche.c Outdated Show resolved Hide resolved
Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
@its0x08
Copy link

@its0x08 its0x08 commented Feb 23, 2022

Looks good!
I was waiting for this 😁
Thank you @jpmenil

@bagder
Copy link
Member

@bagder bagder commented Feb 24, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTTP/3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants