Avoid unused parameter error in Curl_resolv_check#8505
Closed
sgebbie wants to merge 1 commit into
Closed
Conversation
When built without DNS-over-HTTP and without asynchronous resolvers, neither the dns nor the data parameters are used. That is Curl_resolv_check appears to call Curl_resolver_is_resolved(data, dns). But, with CURL_DISABLE_DOH without CURLRES_ASYNCH, the call is actually elided via a macro definition. This fix resolves the resultant: "unused parameter 'data'" error.
bagder
approved these changes
Feb 24, 2022
Member
|
Thanks! |
Contributor
Author
@bagder - Thanks for the quick review and fast turn around. Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When built without DNS-over-HTTP and without asynchronous resolvers,
neither the dns nor the data parameters are used.
That is Curl_resolv_check appears to call
Curl_resolver_is_resolved(data, dns). But,
with CURL_DISABLE_DOH without CURLRES_ASYNCH, the call is actually
elided via a macro definition.
This fix resolves the resultant: "unused parameter 'data'" error.