ngtcp2: Add client certificate authentication for OpenSSL#8522
Closed
tatsuhiro-t wants to merge 1 commit into
Closed
ngtcp2: Add client certificate authentication for OpenSSL#8522tatsuhiro-t wants to merge 1 commit into
tatsuhiro-t wants to merge 1 commit into
Conversation
bagder
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds client certificate authentication for ngtcp2 OpenSSL backend.
See #7625 for the background.
Setting client private key and certificate is a bit complex and done in cert_stuff in lib/vtls/openssl.c. I added a wrapper function around it with the proper CURLcode to expose it to the internal codebase.