http: reject header contents with nul bytes#8601
Closed
bagder wants to merge 2 commits into
Closed
Conversation
Member
Author
|
I made it return |
They are not allowed by the protocol and allowing them risk that curl misbehaves somewhere where c functions are used but won't work on the full contents. Further, they are not supported by hyper and they cause problems for the new coming headers API work. This also makes hyper return the same thing for this error. Updated test 262 to verify and enabled it for hyper as well Closes #8601
bagder
force-pushed
the
bagder/reject-http-zero
branch
from
2fb268d to
d41351d
Compare
It was used for too many other cases as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are not allowed by the protocol and allowing them risk that curl
misbehaves somewhere where c functions are used but won't work on the
full contents. Further, they are not supported by hyper and they cause
problems for the new comign headers API work.
Updated test 262 to verify.