Makefile.m32: add NGTCP2_LIBS option [ci skip]
#9109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
Makefile.m32's ngtcp2 has its two libs hardwired for OpenSSL. Add `NGTCP2_LIBS` envvar to override them with a custom list, making it possible to use BoringSSL, or any other backend.
vszakats
changed the title
NGTCP2_LIBS option [ci skip]
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 6, 2022
Its downside is that this isn't supposed to be used as a dependency, has no versioning or formal releases. TLS-SRP also isn't supported, but its advantages outweigh it. A smaller downside is that it uses pthread even on Windows, which has an issue with static linking, possibly in combination with UCRT builds with the cross-toolchain I tested it with. With this fixed, it's the most promising alternative TLS backend. Binary size is also 2MB lower for both curl EXE and DLL. curl needs two patches, one merged [1], one fixing new iterations of a known issue [2] pending. [1] curl/curl#9109 [2] curl/curl#9110 curl would probably use a third patch from a CMake expert: ngtcp2 detection is broken, so we need to use an local workaround. curl autotools doesn't support BoringSSL because I've found no way to tell libtool to link pthread DLL instead of the static version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Makefile.m32's ngtcp2 has its two libs hardwired for OpenSSL.
Add
NGTCP2_LIBSenvvar to override them with a custom list,making it possible to use BoringSSL, or any other backend.