openssl: add CURL_BORINGSSL_VERSION to identify BoringSSL
#9113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoringSSL doesn't keep a version number, and doesn't self-identify itself via any other revision number via its own headers. BoringSSL revision can be identified by its commit hash. This hash is usually known by the builder. This patch adds a way to pass this hash to libcurl, so that it can display in the curl version string: For example: `CFLAGS=-DCURL_BORINGSSL_VERSION="c239ffd0"` ``` curl 7.84.0 (x86_64-w64-mingw32) libcurl/7.84.0 BoringSSL/c239ffd0 (Schannel) zlib/1.2.12 brotli/1.0.9 libidn2/2.3.2 libssh2/1.10.0 nghttp2/1.48.0 ngtcp2/0.6.0 nghttp3/0.5.0 libgsasl/1.100 Release-Date: 2022-06-27 Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp Features: alt-svc AsynchDNS brotli gsasl HSTS HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Kerberos Largefile libz MultiSSL NTLM SPNEGO SSL SSPI threadsafe UnixSockets ``` The setting is optional, and if not passed, BoringSSL will appear without a version number, just like before this patch.
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 7, 2022
Add upstream PR that is a prerequisite for this [1]. [1] curl/curl#9113
vszakats
changed the title
CURL_BORINGSSL_VERSIONCURL_BORINGSSL_VERSION to identify BoringSSL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
BoringSSL doesn't keep a version number, and doesn't self-identify itself
via any other revision number via its own headers. BoringSSL revision can
be identified by its commit hash. This hash is usually known by the
builder. This patch adds a way to pass this hash to libcurl, so that it
can display in the curl version string:
For example:
CFLAGS=-DCURL_BORINGSSL_VERSION="c239ffd0"The setting is optional, and if not passed, BoringSSL will appear without
a version number, just like before this patch.