Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.m32: reintroduce CROSSPREFIX and -W -Wall [ci skip] #9784

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Oct 22, 2022

  • Reintroduce CROSSPREFIX:

    If set, we add it to the CC and AR values, and to the default value of RC, which is windres. This allows to control each of these individidually, while also allowing to simplify configuration via CROSSPREFIX.

    This variable worked differently earlier. Hopefully this new solution hits a better compromise in usefulness/complexity/flexibility.

    Follow-up to: aa970c4

  • Enable warnings again:

    This time with an option to override it via CFLAGS. Warnings are also enabled by default in CMake, makefile.dj and makefile.amiga builds (not in autotools though).

    Follow-up to 10fbd8b

Closes #xxxx

- Reintroduce `CROSSPREFIX`:

  If set, we add it to the `CC` and `AR` values, and to the _default_
  value of `RC`, which is `windres`. This allows to control each of
  these individidually, while also allowing to simplify configuration
  via `CROSSPREFIX`.

  This variable worked differently earlier. Hopefully this new solution
  hits a better compromise in usefulness/complexity/flexibility.

  Follow-up to: aa970c4

- Enable warnings again:

  This time with an option to override it via `CFLAGS`. Warnings are
  also enabled by default in CMake, `makefile.dj` and `makefile.amiga`
  builds (not in autotools though).

  Follow-up to 10fbd8b

Closes #xxxx
@vszakats vszakats closed this in a0d8a1a Oct 22, 2022
@vszakats vszakats deleted the m32-before-release branch Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant