Unable to save plugin settings when printing unprintable characters to the REPL

[deaddowney]

I get this scary warning when I try to run any Run Configuration in IntelliJ, not just Clojure things:

"Unable to save plugin settings!

The plugin com.cursiveclojure.cursive failed to save settings and has been disabled. Please restart IntelliJ IDEA"

This appears to be due to the fact that I am putting some unprintable characters to the REPL:

Caused by: org.jdom.IllegalDataException: The data "{:repl-history {:ide [], :local ["(defn create-md-entries [symbol levels]\n  (let [currency (ccy/base-ccy symbol)\n        groups (map-i
.....
session-1)))" "(def order-cancel (qfscriptz.to-qfix/string-to-msg \"8=FIX.4.4^A9=208^A35=F^A34=822^A49=OG
GT_ALGO^A52=20140412-04:23:55^A56=713N^A115=PB456^A116=Client123^A11=1si5ozkx00000h^A37=ordId--0412-04:20:37-8^A41=1si5ozkx00000g^A54=1^A55=EUR/USD^A60=20140412-04:23:55.808^A453=0^A583=-0
412-04:20:37-5^A10=144^A\"\n                                                   session-1))" "(defn limit-2[]\n  (set-on-behalf-2 (session/address-to-session (orders/limit-order) session-1)
))" "(def std-order-ack-scenario\n  (create-scenario\n    limit-1\n    (respond-to execs/ack? limit-2)\n    (respond-to execs/ack? limit-1)))" "(defn limit-1 [msg state]\n  (set-on-behalf-
1 (session/address-to-session (orders/limit-order) session-1)))" "(defn limit-1 []\n  (set-on-behalf-1 (session/address-to-session (orders/limit-order) session-1)))" "(defn limit-2[msg sta
te]\n  (set-on-behalf-2 (session/address-to-session (orders/limit-order) session-1)))" "(defn limit1-response[msg state]\n  (limit-1))" "(def std-order-ack-scenario\n  (create-scenario\n  
  limit-1\n    (respond-to execs/ack? limit-2)\n    (respond-to execs/ack? limit1-response)))" "(def r (run-predefined-scenario std-order-ack-scenario test-state))"], :remote []}}" is not 
legal for a JDOM character content: 0x1 is not a legal XML character.
        at org.jdom.Text.setText(Text.java:188)
        at org.jdom.Text.<init>(Text.java:99)
        at org.jdom.Element.addContent(Element.java:822)
        at cursive.config.ClojureSettingsComponent.getState(ClojureSettingsComponent.java:35)
        at cursive.config.ClojureSettingsComponent.getState(ClojureSettingsComponent.java:18)
        at com.intellij.openapi.components.impl.stores.ComponentStoreImpl.a(ComponentStoreImpl.java:148)
        at com.intellij.openapi.components.impl.stores.ComponentStoreImpl.access$600(ComponentStoreImpl.java:43)
        at com.intellij.openapi.components.impl.stores.ComponentStoreImpl$SaveSessionImpl.commit(ComponentStoreImpl.java:448)
        at com.intellij.openapi.components.impl.stores.ComponentStoreImpl.startSave(ComponentStoreImpl.java:105)
        ... 23 more

[cursive-ghost]

That does look scary. I'd assumed that JDOM would automatically escape stored strings, I guess not. I'll fix this.

[cursive-ghost]

BTW to help reproduce this, how are you inserting those characters in the REPL?

[deaddowney]

I was parsing this String, which is a FIX mesage:

"8=FIX.4.4�9=208�35=F�34=822�49=OGGT_ALGO�52=20140412-04:23:55�56=713N�115=PB456�116=Client123�11=1si5ozkx00000h�37=ordId--0412-04:20:37-8�41=1si5ozkx00000g�54=1�55=EUR/USD�60=20140412-04:23:55.808�453=0�583=-0412-04:20:37-5�10=144�"

but I just tried and I can't seem to trigger the exception. If you know what will trigger the JDOM serialization, you could try working with it. I think it has to do with the ^A characters (\u0001)

[cursive-ghost]

Having worked with FIX myself, let me offer my sincere condolences.

I'll also try to fix this bug - thanks for the details.

[deaddowney]

I just tried to run another process and got the exception, so I guess that's what triggers it.

From the error, this line looks like what's causing it:

"(def order-cancel (qfscriptz.to-qfix/string-to-msg "8=FIX.4.4^A9=208^A35=F^A34=822^A49=OGGT_ALGO^A52=20140412-04:23:55^A56=713N^A115=PB456^A116=Client123^A11=1si5ozkx00000h^A37=ordId--0412-04:20:37-8^A41=1si5ozkx00000g^A54=1^A55=EUR/USD^A60=20140412-04:23:55.808^A453=0^A583=-0412-04:20:37-5^A10=144^A"\n session-1))"

[cursive-ghost]

I just tried to reproduce this and I can't. How are you getting that string into the REPL? I tried:

(def order-cancel "8=FIX.4.4^A9=208^A35=F^A34=822^A49=OGGT_ALGO^A52=20140412-04:23:55^A56=713N^A115=PB456^A116=Client123^A11=1si5ozkx00000h^A37=ordId--0412-04:20:37-8^A41=1si5ozkx00000g^A54=1^A55=EUR/USD^A60=20140412-04:23:55.808^A453=0^A583=-0412-04:20:37-5^A10=144^A")
=> (var user/order-cancel)
(spit (clojure.java.io/file "/Users/colin/fixmsg.txt") (str/replace order-cancel "^A" (str (char 1))))
=> nil
(def order-cancel "8=FIX.4.4�9=208�35=F�34=822�49=OGGT_ALGO�52=20140412-04:23:55�56=713N�115=PB456�116=Client123�11=1si5ozkx00000h�37=ordId--0412-04:20:37-8�41=1si5ozkx00000g�54=1�55=EUR/USD�60=20140412-04:23:55.808�453=0�583=-0412-04:20:37-5�10=144�")
=> (var user/order-cancel)

Where in the second def order-cancel the string is the string from the written file pasted into the REPL. On a Mac, at least, I can't seem to get it to put that invalid character in there.

I should definitely fix support for this, but you'd probably be better off replacing the ^A characters in your strings with \u0001.