fix(app-builder): fix SSR hydration mismatch from localStorage#10
Open
falkenbergo wants to merge 1 commit intocursor:mainfrom
Open
fix(app-builder): fix SSR hydration mismatch from localStorage#10falkenbergo wants to merge 1 commit intocursor:mainfrom
falkenbergo wants to merge 1 commit intocursor:mainfrom
Conversation
…match Server-rendered HTML used createInitialAppState() while the client read persisted conversations from localStorage on the first paint, causing React hydration errors (titles, layout classes). Load saved chat state and onboarding visibility in useLayoutEffect after mount so server and client initial trees match. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes React hydration errors in the app builder when saved chat state exists in
localStorage.Previously, the server rendered the default empty state (
createInitialAppState()) while the client immediately read persisted conversations on the first render, so titles, session-derived layout (mainclasses), and onboarding could disagree between SSR and the client.Changes
createInitialAppState()so the first server and client paints match.useLayoutEffectafter hydration.readPersistedAppStateFromStorage()(client-only).Testing
localStoragedata; confirm no hydration warning overlay.Note
Low Risk
Behavior change is limited to client-side state initialization timing to prevent SSR hydration warnings; main risk is minor UI flicker/regressions in restore/onboarding state.
Overview
Fixes React hydration mismatches in
AppBuilderby bootstrapping initial UI state purely fromcreateInitialAppState()(instead of readinglocalStorageduring initial render).After hydration, a
useLayoutEffectnow restores persisted conversations/active conversation and rebuildsruntimeByConversationId, and onboarding is closed when a valid saved Cursor API key is present. The persisted-state loader is renamed/clarified as client-only viareadPersistedAppStateFromStorage().Reviewed by Cursor Bugbot for commit 2298e75. Bugbot is set up for automated code reviews on this repo. Configure here.