Scope `funk` doesn't match on Class methods - ruby

[richardmcmillen]

I was hoping to try and fix this myself as a way to get familiar with how cursorless + tree sitter works but it might take me a bit to get up to speed. Here is the issue:

Given this code:

class Test
  class << self
    # `take funk` doesn't work
    def baz
    end
  end

  # `take funk` doesn't work
  def self.foo
    new.process
  end

  # `take funk` doesn't work
  def Test.bar
    new.process
  end

  # `take funk` works :D
  def process
    puts "process"
  end
end

Current use cases/scopes not covered:

• "change funk" on a function defined self.
• "change funk" on a function defined ClassName.
• "change funk" on a function defined within class << self .... end block

[pokey]

This looks like a bug to me. Go for it!

[pokey]

Fwiw the best place to start is prob the docs for adding a new language. You can ignore a lot of it, eg around using new language PR template etc. We're hoping to refactor those docs a bit so that they are more useful for just fixing up existing language, but hopefully that info gets you in the right direction

[Will-Sommers]

Heyo @richardmcmillen — thanks for adding this and apologies for missing it initially. I added another example in your code example and added a check list. When recording a test, it is best to use change or chuck instead of take since it is easier to see what happened in the test example. Please reach out in Slack if you have any questions or run into problems trying to implement this.

@pokey, no idea what to call whatever is inside class << self, thoughts?

[pokey]

@pokey, no idea what to call whatever is inside class << self, thoughts?

Not sure I follow. What are you planning to use this name for? Wouldn't it just go into "funk"?

[Will-Sommers]

I'm talking about between this block rather than the method definition within it. I agree with you, those methods should just go into funk. I don't actually think we need to name it, but just no idea what I would call it...

Anyway, here's the code:

class << self
.
.
.
end

Any method defined within that block is automatically a class-level method. I need to re-read the docs on how variable definitions within the block works.

[auscompgeek]

That seems somewhat analogous to the class-level static block in Java. I'm not sure we have a name for that either.

Maybe as long as it's selectable using block it shouldn't matter too much?

[pokey]

Could maybe just target it with "inside" or "inside class"?