Fix funk and funk name scope for Ruby Class methods
#782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardmcmillen
force-pushed
the
760-fix-class-method-scope-ruby
branch
4 times, most recently
from
eb31331 to
552e01a
Compare
3 tasks
pokey
reviewed
Jun 23, 2022
There was a problem hiding this comment.
Looks good! See inline comment, and also
- Worth adding a test for "arg" within an arg list for one of these functions
I'll also give @Will-Sommers a chance to have a look
| namedFunction: "method", | ||
| functionName: "method[name]", | ||
| namedFunction: ["method", "singleton_method"], | ||
| functionName: ["method[name]", "singleton_method[name]"], |
There was a problem hiding this comment.
Please also add to name (line 187 below), and add a test for that. Just one test for that one is fine
There was a problem hiding this comment.
Sorry I missed this suggestion in the issue @richardmcmillen!
richardmcmillen
force-pushed
the
760-fix-class-method-scope-ruby
branch
from
552e01a to
ffa39d9
Compare
Tree sitter sees these as `singleton_methods` and this was missing from the `namedFunction` and `functionName` definitions.
richardmcmillen
force-pushed
the
760-fix-class-method-scope-ruby
branch
from
ffa39d9 to
fd47787
Compare
I added a new test case which I think covers this if I understand correctly, and make the other change as well. |
pokey
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree sitter sees these as
singleton_methodsand this was missing fromthe
namedFunctionandfunctionNamedefinitions.Checklist
Fixes #760