Skip to content

Added support to exclude start or end token in ranges#131

Merged
AndreasArvidsson merged 5 commits intodevelopfrom
excludeInRanges
Jul 24, 2021
Merged

Added support to exclude start or end token in ranges#131
AndreasArvidsson merged 5 commits intodevelopfrom
excludeInRanges

Conversation

@AndreasArvidsson
Copy link
Copy Markdown
Member

@AndreasArvidsson AndreasArvidsson commented Jul 21, 2021

For the air till bat commands

@AndreasArvidsson AndreasArvidsson requested a review from pokey as a code owner July 21, 2021 20:02
@AndreasArvidsson AndreasArvidsson linked an issue Jul 21, 2021 that may be closed by this pull request
@AndreasArvidsson AndreasArvidsson changed the base branch from master to develop July 24, 2021 21:48
Copy link
Copy Markdown
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some minor comments. This range code is def complex haha

Comment thread src/inferFullTargets.ts Outdated
Comment thread src/processTargets.ts
Comment thread src/processTargets.ts Outdated
Comment thread src/processTargets.ts Outdated
@AndreasArvidsson AndreasArvidsson merged commit 7b24e21 into develop Jul 24, 2021
@AndreasArvidsson AndreasArvidsson deleted the excludeInRanges branch July 24, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support "until"

2 participants