Converted test recorder for bulk recordings#169
Merged
AndreasArvidsson merged 7 commits intomasterfrom Aug 1, 2021
Merged
Conversation
Merged
AndreasArvidsson
changed the title
pokey
reviewed
Aug 1, 2021
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
I think this is mostly a win but see my two comments
pokey
reviewed
Aug 1, 2021
| start: {line: 0, character: 6} | ||
| end: {line: 0, character: 21} | ||
| initialState: | ||
| documentContents: "const myVariableValue = \"hello\";\r\n" |
Member
There was a problem hiding this comment.
Hmm. So I don't think it's worth re-recording everything, but I believe if you don't use line feeds these will get turned into block output and be a bit nicer to read. At least I think that's what's happening here. Check out the example yamls
pokey
reviewed
Aug 1, 2021
| - anchor: {line: 1, character: 0} | ||
| active: {line: 1, character: 0} | ||
| finalState: | ||
| documentContents: "\r\nconst myVariableValue = \"hello\";\r\n" |
Member
There was a problem hiding this comment.
Does VSCode auto-detect line ending type? If not then this will fail in some cases I believe
pokey
approved these changes
Aug 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.