Conversation
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
This LGTM but we should potentially file issues for those two behaviours I call out below if you agree they should change
| - anchor: {line: 1, character: 9} | ||
| active: {line: 1, character: 0} |
There was a problem hiding this comment.
Do we want these reversed? I can see the logic, but I'd imagine it's more common to want it forward, so would prob make sense to have that be the default
There was a problem hiding this comment.
I really like them like they are to be honest. Its define as past start of line after all.
There was a problem hiding this comment.
And to be real these modifers are mostly usefull for chuck or clear. With a take it doesn't really matter where the active is because its gonna get overwritten if you insert anything.
There was a problem hiding this comment.
Fair enough; if they're working well for you this way and it's simpler let's leave them!
| - anchor: {line: 1, character: 0} | ||
| active: {line: 3, character: 28} |
There was a problem hiding this comment.
So "down three" is a mark, not a modifier? I guess fine for now but I'd argue that long term we want it as a modifier
There was a problem hiding this comment.
Yes up and down always align with vscode relative line number. This is just a stopgap intill we have the full "next" syntax working.
2 participants
No description provided.