Conversation
pokey
reviewed
Aug 13, 2021
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Overall looks good with a few comments. Also might add one test with nesting. Eg foo(bar(baz, bongo), bazman)
Comment on lines
+28
to
+35
| - anchor: {line: 1, character: 4} | ||
| active: {line: 1, character: 17} | ||
| - anchor: {line: 2, character: 4} | ||
| active: {line: 2, character: 17} | ||
| - anchor: {line: 1, character: 4} | ||
| active: {line: 1, character: 17} | ||
| - anchor: {line: 2, character: 4} | ||
| active: {line: 2, character: 17} |
Member
There was a problem hiding this comment.
Is this really what we want? Appears selections are duplicated
Member
Author
There was a problem hiding this comment.
Agreed, but has actually nothing to do with this pr. transformSelection/getNodeMatcher gets called for every selection. But might be a good idea to actually filter out duplicate selections at the end of the pipeline. You should probably put that on the task list for the new grammar.
pokey
approved these changes
Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #220
Added a few tests