Conversation
pokey
commented
Aug 20, 2021
Comment on lines
+18
to
+19
| # %% | ||
| print("hello") |
Member
Author
There was a problem hiding this comment.
whoops. looks like (shockingly) the jupyter.insertCellAbove command returns a promise that resolves before the action is actually complete, so test recorder shows nothing having changed. awesome. so do we keep the test to just make sure nothing errors, delete the test, or insert some random sleep? cc/ @AndreasArvidsson @brxck
Member
There was a problem hiding this comment.
Wtf they dont ubderstand how a promise work do they?
I dont really care since we cant actually test it.
Collaborator
There was a problem hiding this comment.
Yikes. If it were up to me I would leave the test as is with a note. I don't think it's worth it to accommodate with a sleep, we're never going to be 100% tests anyhow.
AndreasArvidsson
previously approved these changes
Aug 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on cursorless-dev/cursorless-talon#63