Renames for csv overrides PR#248
Conversation
| includeAnchor?: boolean; | ||
| includeActive?: boolean; |
There was a problem hiding this comment.
making these optional for now for backwards compatibility. Also, I went with "include" instead of "exclude" because I prefer positive booleans, otherwise it's a double negative when they're false which is a bit more cognitive load
my one hesitation with using "include" instead of "exclude" is that while these are optional, we'll be defaulting to true, which is always a bit jarring cc/ @AndreasArvidsson
There was a problem hiding this comment.
I will always prefer that optional booleans default to false. That why they were defined as excluding.
There was a problem hiding this comment.
Yes but I would prefer to make these not optional. The reason they're optional is for backwards compatibility. Hmm. I'm not seeing a way to make them backwards compatible while making them positive. Any ideas?
There was a problem hiding this comment.
In Infer full targets just do.
Includeachor = target.includeanchor ?? true
There was a problem hiding this comment.
Wait isn't that defaulting to true?
There was a problem hiding this comment.
Yes and that is how it is today
Many changes to support the new names in csv overrides PR. This PR also does the following:
Todo: