Merged
Conversation
pokey
commented
Aug 26, 2021
| } = {}; | ||
|
|
||
| static getKey(color: SymbolColor, character: string) { | ||
| static getKey(color: HatStyleName, character: string) { |
Member
Author
There was a problem hiding this comment.
- rename all the
colorvars in this file (and other necessary places) tohatStyleName
pokey
commented
Aug 26, 2021
| export type HatColor = typeof HAT_COLORS[number]; | ||
| export type HatGlyphName = typeof HAT_GLYPHS[number]; | ||
| type HatNonDefaultGlyph = typeof HAT_NON_DEFAULT_GLYPHS[number]; | ||
| export type HatStyleName = HatColor | `${HatColor}-${HatNonDefaultGlyph}`; |
Member
Author
There was a problem hiding this comment.
Finally got to use those template literal types 😊
pokey
force-pushed
the
multiple-hat-styles
branch
from
d88b856 to
520595e
Compare
pokey
force-pushed
the
multiple-hat-styles
branch
from
5b005dd to
09c590c
Compare
AndreasArvidsson
approved these changes
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently three styles, but I think we can get a couple more in there
Note that this PR also increases default circle hat size
mastercolorvariables tohatStyleName(see comment below)disabled/penalty