Fix copy when focus is not on editor#255
Merged
AndreasArvidsson merged 2 commits intomasterfrom Sep 1, 2021
Merged
Conversation
pokey
commented
Sep 1, 2021
|
|
||
| editor.selections = targetSelections; | ||
| // For command to the work we have to have the correct editor focused | ||
| await setSelectionsAndFocusEditor(editor, targetSelections, false); |
Member
Author
There was a problem hiding this comment.
When setting selections and focusing editor it is important to first set the selections and then focus the editor. This was fixed in the setSelectionsAndFocusEditor function but because it wasn't used here we didn't get that fix
AndreasArvidsson
approved these changes
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, we aren't able to set focus back to where it was before, eg a search box. Maybe this argues for switching back to our own copy implementation?