Fix "take every value" in python#258
Conversation
pokey
changed the title
| namedFunction: "decorated_definition?.function_definition", | ||
| functionName: "function_definition[name]", | ||
| type: ["function_definition[return_type]", "*[type]"], | ||
| type: valueMatcher("function_definition[return_type]", "*[type]"), |
There was a problem hiding this comment.
This change is so that the leading : gets deleted when using "chuck type"
| - anchor: {line: 0, character: 2} | ||
| active: {line: 0, character: 2} | ||
| finalState: | ||
| documentContents: "foo: str " |
There was a problem hiding this comment.
We should prob clean up this trailing string too, but prob best to leave that one for object-oriented targets refactor
|
I'm unsure. I think this could be a reoccurring problem in different languages. One solution could be that we do an ancestral crawl and just pick the highest match. Maybe should have dialogue about this before doing anything? |
not sure i follow; yes let's discuss |
2 participants
Fixes #257
Mixed feelings about this solution. There is no way to exclude two types, for example.
The alternative would be to explicitly list the types that we want to allow user to use "value" field with. There are about 7