Conversation
pokey
commented
Sep 6, 2021
| node: SyntaxNode | ||
| ): SelectionWithContext { | ||
| const leadingDelimiterToken = node.previousSibling; | ||
| const leadingNonDelimiterToken = node.previousSibling?.previousSibling; |
Member
Author
There was a problem hiding this comment.
Note that we now use the end of the token before the delimiter rather than the start of the delimiter itself. This way, for example, if you have foo = bar and say "chuck value", you won't get the trailing space after foo. See changed test case above (chuckValue)
AndreasArvidsson
approved these changes
Sep 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows saying "chuck key" and having the trailing
:cleaned up