Skip to content

Comments

Replace flynt with ruff FLY rules and bump pre-commit hooks#3169

Merged
AndreasArvidsson merged 3 commits intomainfrom
replace-flynt-bump-precommit
Feb 24, 2026
Merged

Replace flynt with ruff FLY rules and bump pre-commit hooks#3169
AndreasArvidsson merged 3 commits intomainfrom
replace-flynt-bump-precommit

Conversation

@phillco
Copy link
Member

@phillco phillco commented Feb 14, 2026

Summary

Closes #2308, closes #1885

Test plan

  • ruff check passes clean
  • ruff format --check passes clean
  • pnpm run compile passes
  • Pre-commit CI passes

- Remove flynt hook; ruff's FLY002 + existing UP031/UP032 rules cover
  the same f-string conversions
- Bump hook versions: pre-commit-hooks v4.4.0→v6.0.0, Lucas-C
  v1.5.1→v1.5.6, ruff v0.4.1→v0.15.1
- Bump minimum_pre_commit_version to 3.2.0 (required by pre-commit-hooks v6)
- Add FLY to ruff select, add UP045 to ignore (same Talon runtime
  issue as UP007; see talonvoice/talon#634)
- Apply ruff autofixes: SIM905 in default_vocabulary.py, C420 in
  destinations.py

Closes #2308, closes #1885
@phillco phillco requested a review from a team as a code owner February 14, 2026 18:52
@AndreasArvidsson AndreasArvidsson merged commit 2b23911 into main Feb 24, 2026
11 of 15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the replace-flynt-bump-precommit branch February 24, 2026 03:35
cursorless-bot pushed a commit that referenced this pull request Feb 24, 2026
## Summary

- Remove the `flynt` pre-commit hook — ruff's `FLY002` rule (plus
existing `UP031`/`UP032`) covers the same f-string conversions
- Bump hook versions: `pre-commit-hooks` v4.4.0→v6.0.0, `Lucas-C`
v1.5.1→v1.5.6, `ruff` v0.4.1→v0.15.1
- Bump `minimum_pre_commit_version` to 3.2.0 (required by
`pre-commit-hooks` v6)
- Add `FLY` to ruff lint select; add `UP045` to ignore list (same Talon
runtime issue as `UP007` — see talonvoice/talon#634, tracked in #2151)
- Apply ruff autofixes: `SIM905` in `default_vocabulary.py`, `C420` in
`destinations.py`

Closes #2308, closes #1885

## Test plan

- [x] `ruff check` passes clean
- [x] `ruff format --check` passes clean
- [x] `pnpm run compile` passes
- [x] Pre-commit CI passes

---------

Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch from flynt to ruff Bump pre-commit version

3 participants