Replace glob with fast glob#3235
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Sort command-history files before analyzing them
Because fast-glob returns matches in arbitrary order, getEntries() is no longer deterministic here. analyzeCommandHistory() later renders month sections in first-seen order via Object.entries(groupBy(entries, getMonth)) in packages/lib-engine/src/CommandHistoryAnalyzer.ts, so anyone with more than one cursorlessCommandHistory_YYYY-MM.jsonl file can now get month blocks in a random order instead of chronological order. Sorting the filenames before reading them preserves the previous report layout.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
AndreasArvidsson
requested review from
a team,
fidgetingbits and
saidelike
as code owners
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
No description provided.