Conversation
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Ok nice tests thanks. Left a few more comments. I think I found a case we're missing
| }); | ||
|
|
||
| return { | ||
| thatMark: targets.map((target) => target.selection), |
There was a problem hiding this comment.
Do you think the that mark would be more useful if it were the selections that got dropped? We could probably just leave it for now and see how it works in practice but just a thought
There was a problem hiding this comment.
I think we can leave it like this and try it out. In most cases that is token you actually referenced. But I do agree that could potentially be useful.
Maybe we can use the source mark?
There was a problem hiding this comment.
Hmm not sure source mark is right here but interesting idea. Agreed tho let's just see if we ever actually want a way to refer to the removed selections in practice
Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
…into removeSelection
2 participants
Closes #95