Merged
Conversation
pokey
reviewed
Dec 2, 2021
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
This is super cool! Left a few minor comments but otherwise looks good
pokey
approved these changes
Dec 2, 2021
| const delta = isForward ? 1 : -1; | ||
| const results: TypedSelection[] = []; | ||
|
|
||
| for (let i = anchorLine; true; i += delta) { |
Member
There was a problem hiding this comment.
This would be a bit cleaner imo with a loadash range + map but not worth rewriting; maybe something to play with next time
Member
Author
There was a problem hiding this comment.
I must admit that I'm not a big fan of lodash. But you're probably right in this case and I did think about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selection type to create multiple selections in a column between two targets instead of a continuous range
Right now doesn't do anything without a ranged target.
fixes #345