Skip to content

Change column modified to range vertical connector#353

Merged
AndreasArvidsson merged 8 commits intomainfrom
verticalRange
Dec 8, 2021
Merged

Change column modified to range vertical connector#353
AndreasArvidsson merged 8 commits intomainfrom
verticalRange

Conversation

@AndreasArvidsson
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor tweaks

Comment thread src/core/inferFullTargets.ts Outdated
Comment thread src/typings/Types.ts Outdated
@pokey pokey added this to the 0.24.0 milestone Dec 7, 2021
@AndreasArvidsson
Copy link
Copy Markdown
Member Author

@pokey The format of the test has changed and I can't figure it out. Can you solve the conflicts?

Copy link
Copy Markdown
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment

Comment thread src/typings/Types.ts Outdated
@AndreasArvidsson
Copy link
Copy Markdown
Member Author

@pokey More merge conflicts due to change in test format

@AndreasArvidsson AndreasArvidsson merged commit 66f160e into main Dec 8, 2021
@AndreasArvidsson AndreasArvidsson deleted the verticalRange branch December 8, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants