Skip to content

Disabled statement block on typescript#359

Merged
pokey merged 1 commit intomainfrom
typescript_statement
Dec 5, 2021
Merged

Disabled statement block on typescript#359
pokey merged 1 commit intomainfrom
typescript_statement

Conversation

@AndreasArvidsson
Copy link
Copy Markdown
Member

At the moment a statement in typescript will just captured a block/body of if statements and loops. Disabling statement block makes the ancestral crawl find the entire statement instead.

@pokey
Copy link
Copy Markdown
Member

pokey commented Dec 5, 2021

Weird. So this issue only arises if you are within the body of the if statement but not within one of its nested statements, correct? Trying to figure out why I've never encountered it before. I usually "take state" in the guard / if keyword, so I guess this one hasn't hit me

@AndreasArvidsson
Copy link
Copy Markdown
Member Author

You have to be inside the curly braces. In that case you will only select inside the braces and not the entire statement.

Copy link
Copy Markdown
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@pokey pokey merged commit 23fe4db into main Dec 5, 2021
@pokey pokey deleted the typescript_statement branch December 5, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants