Reworked decorations debounce delay with special exception for scrolling#377
Merged
AndreasArvidsson merged 4 commits intomainfrom Dec 16, 2021
Merged
Reworked decorations debounce delay with special exception for scrolling#377AndreasArvidsson merged 4 commits intomainfrom
AndreasArvidsson merged 4 commits intomainfrom
Conversation
pokey
reviewed
Dec 11, 2021
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Looks good but I'd like to have a quick play with it before we merge
Member
|
Ok just wired it up. Def nice to get that 16ms thing, but I think 40ms is a bit fast for scroll, as there are a bunch of refreshes as my momentum scrolling slows at the end. Maybe we could bump it up a little bit, or make it a setting? |
pokey
approved these changes
Dec 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed single setting for debounce delay and replaced with two different default values.
60Hz for all decorations except visible ranges at 25Hz to improve performance and remove annoyance when scrolling.