Fixed selection bug and added source mark to copy lines#384
Merged
AndreasArvidsson merged 4 commits intomainfrom Dec 12, 2021
Merged
Fixed selection bug and added source mark to copy lines#384AndreasArvidsson merged 4 commits intomainfrom
AndreasArvidsson merged 4 commits intomainfrom
Conversation
Member
AndreasArvidsson
commented
Dec 12, 2021
AndreasArvidsson
commented
- Since is replaced was false empty selections at the end was incorrectly moved
- Added source mark
pokey
approved these changes
Dec 12, 2021
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Looks good with some minor comments. Worth adding a test for "clone up" / "clone down" with cursor at start of line, because I believe there's a bug in "clone up" with cursor at start of line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.