Conversation
|
Tempted to introduce visible ranges to recorded tests for this one. As long as the file fits within a reasonable sized window I think it should be fairly straightforward |
I think that should probably be fine |
pokey
left a comment
There was a problem hiding this comment.
Ok I'm going to approve this one without tests because adding support for visible range testing is probably out of scope for this PR. But it would be good to add that as a fast follow, because this folding stuff is getting a bit more complex than I'm comfortable not having tests for 😅
@AndreasArvidsson rather than requesting tests on this PR, I'll assign #160 to you to do after this one is merged in so that we don't clutter this PR. I think it actually should be fairly straightforward. But if you don't have capacity no worries feel free to assign it to me
Re enabled folding of single line. To "solve" the problem where
fold every statewill fold the parent if one of the states is a single line I added a constraint that you can't combine multi and single line targets. In that case just used the multiline targets. Multiple single line targets is fine though.fixes #72