feat: llamalend mobile view #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
refactor: column IDs without dots
DanielSchiavini
force-pushed
the
feat/llama-mobile
branch
from
94085d2 to
c7fb072
Compare
DanielSchiavini
requested review from
0xAlunara,
0xtutti,
OnlyJousting and
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the mobile view for the Llamalend table by adding an expansion panel, streamlining banner height management using a central hook, and updating several layout and filter components to support improved responsiveness. Key changes include:
- Updating enum key naming conventions for market columns.
- Overhauling several UI components (e.g. MarketTitleCell, MarketsFilterChips, LendingMarketsTable) for better mobile responsiveness.
- Revising layout hooks and configurations in multiple files along with updated installation instructions in the README.
Reviewed Changes
Copilot reviewed 60 out of 60 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/main/src/loan/components/PageLlamaMarkets/columns.enum.ts | Revised enum keys to use underscores instead of dots. |
| apps/main/src/loan/components/PageLlamaMarkets/cells/MarketTitleCell/MarketTitleCell.tsx | Added mobile-specific behavior and updated layout styles. |
| apps/main/src/loan/components/PageLlamaMarkets/cells/MarketBadges.tsx | Replaced inline favorite button logic with a dedicated component and adjusted badge labels for mobile. |
| apps/main/src/loan/components/PageLlamaMarkets/Page.tsx | Adjusted outer container margins for better spacing on mobile. |
| apps/main/src/loan/components/PageLlamaMarkets/MarketsFilterChips.tsx | Migrated from Stack to Grid for improved responsive layouts. |
| apps/main/src/loan/components/PageLlamaMarkets/LlamaMarketExpandedPanel.tsx | Introduced an expansion panel component for detailed market information. |
| apps/main/src/loan/components/PageLlamaMarkets/LendingMarketsTable.tsx | Enabled expanded rows and mobile column visibility; integrated new sorting options. |
| apps/main/src/loan/components/PageLlamaMarkets/LendingMarketsFilters.tsx | Updated filter configurations with explicit id and field values. |
| apps/main/src/loan/components/PageLlamaMarkets/FavoriteMarketButton.tsx | Created a reusable favorite button component. |
| apps/main/src/lend/store/types.ts & createLayoutSlice.ts | Removed footer height to streamline layout configuration. |
| Various layout files (lend, dex, dao) | Updated hook usage for layout height management. |
| README.md | Revised installation and version requirements. |
Comments suppressed due to low confidence (1)
apps/main/src/loan/components/PageLlamaMarkets/columns.enum.ts:8
- Ensure that all consumers of these enum values are updated to match the revised naming convention using underscores instead of dots to prevent potential mismatches.
BorrowRate = 'rates_borrow',
apps/main/src/loan/components/PageLlamaMarkets/cells/MarketTitleCell/MarketTitleCell.tsx
Outdated
Show resolved
Hide resolved
apps/main/src/loan/components/PageLlamaMarkets/LendingMarketsFilters.tsx
Show resolved
Hide resolved
apps/main/src/loan/components/PageLlamaMarkets/LendingMarketsFilters.tsx
Show resolved
Hide resolved
0xAlunara
reviewed
May 21, 2025
Collaborator
0xAlunara
left a comment
0xAlunara
left a comment
There was a problem hiding this comment.
It's a big PR, many moving parts (and many more to come most likely)
| const [isOpen, open, close] = useSwitch(false) | ||
| const selectedOption = useMemo(() => options.find((option) => option.id === value), [options, value]) | ||
|
|
||
| // the select component does a lot of stuff with its children, so we cannot add a wrapper for the theme inverter. |
Collaborator
There was a problem hiding this comment.
Yikes nasty copy/paste. I'm starting to need to use the new Select more often myself as well so maybe we should attach a higher prio to creating a proper Select wrapper component.
Collaborator
Author
There was a problem hiding this comment.
This something different than the other selects; However, I agree we need to create something easier to use!
0xAlunara
approved these changes
May 21, 2025
0xtutti
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useLayoutHeighthook