fix: hodgepodge #983
Merged
fix: hodgepodge #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 23, 2025 15:11
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DanielSchiavini
previously approved these changes
May 23, 2025
Collaborator
DanielSchiavini
left a comment
DanielSchiavini
left a comment
There was a problem hiding this comment.
Thanks for teaching me a new word 😆 I've never heard of hodgepodges
packages/curve-ui-kit/src/features/connect-wallet/ui/ConnectWalletIndicator.tsx
Outdated
Show resolved
Hide resolved
OnlyJousting
approved these changes
May 23, 2025
DanielSchiavini
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hodgepodge of a handful of review comments and own small commits that I don't want to clog the soft liquidation PR with. Mainly concerns action infos and the large token input.
The reason why I want to use
SystemStyleObjectforsxprops consistently instead ofSxProps, is becauseSxPropsdoesn't work with if the object contains a function likecolor: t => t.design.Colors[200]. Functionally this change doesn't change anything, it's just a typescript thing and I don't want to re figure out the solution when SxProps isn't working properly. Rather be consistent.