feat: extracted rbac into a separate class. #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # smart_contracts/artifacts/base_d_asa/BaseDAsa.approval.puya.map # smart_contracts/artifacts/base_d_asa/BaseDAsa.approval.teal # smart_contracts/artifacts/base_d_asa/BaseDAsa.arc32.json # smart_contracts/artifacts/base_d_asa/base_d_asa_client.py # smart_contracts/artifacts/fixed_coupon_bond/FixedCouponBond.approval.puya.map # smart_contracts/artifacts/fixed_coupon_bond/FixedCouponBond.approval.teal # smart_contracts/artifacts/fixed_coupon_bond/FixedCouponBond.arc32.json # smart_contracts/artifacts/fixed_coupon_bond/fixed_coupon_bond_client.py # smart_contracts/artifacts/perpetual_bond/PerpetualBond.approval.puya.map # smart_contracts/artifacts/perpetual_bond/PerpetualBond.approval.teal # smart_contracts/artifacts/perpetual_bond/PerpetualBond.arc32.json # smart_contracts/artifacts/perpetual_bond/perpetual_bond_client.py # smart_contracts/artifacts/zero_coupon_bond/ZeroCouponBond.approval.puya.map # smart_contracts/artifacts/zero_coupon_bond/ZeroCouponBond.approval.teal # smart_contracts/artifacts/zero_coupon_bond/ZeroCouponBond.arc32.json # smart_contracts/artifacts/zero_coupon_bond/zero_coupon_bond_client.py # smart_contracts/base_d_asa/contract.py
cusma
reviewed
Jan 22, 2025
Owner
cusma
left a comment
cusma
left a comment
There was a problem hiding this comment.
The proposed abstraction is good.
I think a couple of things are missing in the PR:
- The RBAC contract should contain the
assign_roleandrevoke_rolemethods; - The RBAC contract should have its own unit tests;
- The RBAC must be included in the
d-asa-ciworkflow (both contract and testdifffilter and related conditional step).
Owner
There was a problem hiding this comment.
This class should contain also the assign_role and revoke_role methods.
cusma
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.