Dev dyer #5
Merged
Dev dyer #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge notes file into main octupus
Create python-app.yml
should run on all pushes
…cture to dev file.
…substance (currently only nitrous) from a polynomial. Also began an orifice class (still non-functional) that will make use of the enthalpy function.
…ter for properties. Note that Chemical.Cp appears to be producing bogus results for nitrous, and needs to be fixed. Currently the expression is replaced by the value at 255K for debug.
…ons affecting results, take a look.
… the bug causing the supercritical polynomial to be used by the thermo solver for Cp if a temperature under 65K was not computed previously in that runtime since the last calculation of a supercritical Cp or the beginning of the runtime.
Refactored `Manifold` code to be compatible with new `Chemical`-inherited `Fluid`
octopus.Fluid changes
current issues: -Solver finds solutions, but they appear to increase mass flow rate as you approach pressure drop=0, and continue to climb with inverse drops. -Entropy is calculated assuming that liquid and gaseous entropies are equal at a value close to the critical point, which may be causing integration errors -specific volume can be calculated in many ways, to produce many different results, as far as i can see the current solution is accurate. Help is welcomed
converting EOS to helmholz. Issues: - Solver does not reliably predict saturation densities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.