Skip to content

Conversation

@Ernst79
Copy link
Collaborator

@Ernst79 Ernst79 commented Nov 27, 2019

@Ernst79 Ernst79 requested a review from Magalex2x14 November 27, 2019 15:59
@Ernst79
Copy link
Collaborator Author

Ernst79 commented Nov 27, 2019

@Magalex2x14 Can you check if all variables work. I was able to see that decimals and period work fine, the others I'm not sure how to check if they work.

Example of the configuration

sensor:
  - platform: mitemp_bt
    rounding: True
    decimals: 3
    period: 60
    log_spikes: False
    use_median: True
    hcitool_active: False

@Magalex2x14
Copy link
Collaborator

Yes, today a little later I will have the opportunity to check. I’ll write how I’ll finish. At the same time I can add a commit with readme update.

@Ernst79
Copy link
Collaborator Author

Ernst79 commented Nov 27, 2019

I added the description that you had in the python code in the README,md and info.md. You can just modify it.

Copy link
Collaborator

@Magalex2x14 Magalex2x14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operation of the parameters is checked, everything is fine.

@Magalex2x14
Copy link
Collaborator

@Ernst79 Please look at my changes in the readme and info.md, and feel free to correct my English, if it's necessary )

@Ernst79 Ernst79 merged commit da40f48 into master Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the Vars_to_configuration branch November 27, 2019 21:18
@Magalex2x14
Copy link
Collaborator

Thank you

@Ernst79
Copy link
Collaborator Author

Ernst79 commented Nov 27, 2019

Glad I could help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variables are overwritten with update

3 participants