Skip to content

chore: modules optional with flags#331

Merged
Shahroz16 merged 4 commits intofeature/spm-supportfrom
spm-optional-module
Apr 10, 2026
Merged

chore: modules optional with flags#331
Shahroz16 merged 4 commits intofeature/spm-supportfrom
spm-optional-module

Conversation

@Shahroz16
Copy link
Copy Markdown
Collaborator

@Shahroz16 Shahroz16 commented Apr 8, 2026

Note

Medium Risk
Build-time dependency selection now depends on reading android/gradle.properties or env vars, which could unexpectedly include/exclude the Location module depending on project layout and CI environment.

Overview
Makes the Location dependency opt-in for the iOS Swift Package by building targetDependencies dynamically instead of always linking it.

Adds logic in ios/customer_io/Package.swift to detect an enable flag from android/gradle.properties (walking up parent directories) with a fallback to CIO_LOCATION, and only appends Location when enabled.

Reviewed by Cursor Bugbot for commit b8a26ee. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • flutter_sample_spm: 331.4.0 (29596557)

@Shahroz16 Shahroz16 marked this pull request as ready for review April 10, 2026 03:50
@Shahroz16 Shahroz16 requested a review from a team as a code owner April 10, 2026 03:50
@Shahroz16 Shahroz16 self-assigned this Apr 10, 2026
Copy link
Copy Markdown
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran some tests and it looks good 👍🏻

@Shahroz16 Shahroz16 merged commit 72f678a into feature/spm-support Apr 10, 2026
15 checks passed
@Shahroz16 Shahroz16 deleted the spm-optional-module branch April 10, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants