chore: modules optional with flags#331
Merged
Shahroz16 merged 4 commits intofeature/spm-supportfrom Apr 10, 2026
Merged
Conversation
Contributor
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mrehan27
approved these changes
Apr 10, 2026
Contributor
mrehan27
left a comment
There was a problem hiding this comment.
Ran some tests and it looks good 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Build-time dependency selection now depends on reading
android/gradle.propertiesor env vars, which could unexpectedly include/exclude theLocationmodule depending on project layout and CI environment.Overview
Makes the
Locationdependency opt-in for the iOS Swift Package by buildingtargetDependenciesdynamically instead of always linking it.Adds logic in
ios/customer_io/Package.swiftto detect an enable flag fromandroid/gradle.properties(walking up parent directories) with a fallback toCIO_LOCATION, and only appendsLocationwhen enabled.Reviewed by Cursor Bugbot for commit b8a26ee. Bugbot is set up for automated code reviews on this repo. Configure here.