CDP-5966: make getCustomersByEmail query-safe (drop cleanEmail, use encodeURIComponent)#193
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7ad38bb. Configure here.
senechko
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Fixes
getCustomersByEmailto correctly encode the full email value in the query string. The previouscleanEmailhelper only encoded each side of@separately, leaving reserved characters like&,#, and?unencoded — corrupting the query string.Changes
lib/utils.ts— removecleanEmailhelper (no other callers).lib/api.ts— replacecleanEmail(email)withencodeURIComponent(email)ingetCustomersByEmail. RemovecleanEmailimport.test/util.ts— removecleanEmailtests (helper no longer exists).test/api.ts— update existing default test to expectencodeURIComponentoutput. Add two new tests covering emails with reserved characters (&,+,#,?).Closes CDP-5966.
Note
Low Risk
Low risk: small change to URL encoding for a single API call plus accompanying test updates; behavior only differs for emails containing reserved URL characters.
Overview
Fixes
APIClient.getCustomersByEmailto build a query-safe request by encoding the entire email withencodeURIComponentinstead of the removedcleanEmailhelper.Removes
cleanEmailfromlib/utils.ts, deletes its unit test, and updates/addstest/api.tscoverage to assert correct encoding for reserved characters like&,#, and?.Reviewed by Cursor Bugbot for commit 3e4fc10. Bugbot is set up for automated code reviews on this repo. Configure here.