Allow request options to be overridden#26
Merged
mike-engel merged 1 commit intocustomerio:masterfrom Mar 5, 2020
Merged
Conversation
Collaborator
|
Hey @nunofgs! Thanks for the PR, this seems like a great addition. Before we merge it in, however, can you add a test to make sure the default is still 10,000? You're testing now for 5,000, which is good, but it would be good to make sure the default is still in place. |
nunofgs
force-pushed
the
bugfix/allow-request-options-to-be-overridden
branch
from
4ebe7c9 to
69c6f3b
Compare
Contributor
Author
|
Absolutely, I've added it. Thanks @mike-engel |
Collaborator
|
@nunofgs Sorry to ask more of you again, but would you mind rebasing master into this PR? I'll merge it in once there aren't any conflicts. Thanks! |
nunofgs
force-pushed
the
bugfix/allow-request-options-to-be-overridden
branch
from
69c6f3b to
cb15cc6
Compare
Contributor
Author
|
@mike-engel of course, no worries. Pushed. |
Collaborator
|
@nunofgs Thank you for your patience! This is now in as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows request options to be overridden. In particular, it allows customizing the default 10s timeout.