Skip to content

add support for sending transactional in-app messages#129

Merged
avigoldman merged 1 commit intomainfrom
add-send-in-app
Apr 28, 2026
Merged

add support for sending transactional in-app messages#129
avigoldman merged 1 commit intomainfrom
add-send-in-app

Conversation

@avigoldman
Copy link
Copy Markdown
Contributor

@avigoldman avigoldman commented Apr 28, 2026

Adds SendInAppRequest and APIClient#send_in_app for the POST /v1/send/in_app endpoint. Follows the same pattern as the existing inbox message support.


Note

Low Risk
Low risk: adds a new send_in_app request type and API client method following existing send patterns, with no changes to existing endpoints or shared request/response handling.

Overview
Adds support for transactional in-app sends by introducing SendInAppRequest and wiring APIClient#send_in_app to call POST /v1/send/in_app with the same success/400/other error handling used by other send endpoints.

Updates the gem entrypoint (lib/customerio.rb) to require the new request type and adds API client specs covering success, validation (400), and server error (5xx) cases for send_in_app.

Reviewed by Cursor Bugbot for commit 72d20eb. Bugbot is set up for automated code reviews on this repo. Configure here.

Add SendInAppRequest class and APIClient#send_in_app method for the
POST /v1/send/in_app endpoint. Follows the same pattern as the existing
inbox message support.
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 72d20eb. Configure here.

Base64.strict_encode64(data)
end
end
end
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New request class is exact duplicate of existing class

Low Severity

SendInAppRequest is a line-for-line duplicate of SendInboxMessageRequest — identical REQUIRED_FIELDS, OPTIONAL_FIELDS, initialize, invalid_field?, and an unused encode method. If a bug is fixed in one class it could easily be missed in the other. A shared base class or module mixin would eliminate this duplication.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 72d20eb. Configure here.

@avigoldman avigoldman merged commit c48836e into main Apr 28, 2026
19 checks passed
@avigoldman avigoldman deleted the add-send-in-app branch April 28, 2026 17:21
@avigoldman avigoldman mentioned this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants