patch: set span name as tag

[alexopenline]

Important

Change span attribute key from name to operation.name in StartSpan() in helpers.go.

• Behavior:
  • In StartSpan() in helpers.go, change span attribute key from name to operation.name for OpenTelemetry spans.

^{This description was created by for da8d849. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to da8d849 in 41 seconds. Click for details.

• Reviewed 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. internal/telemetry/helpers.go:102

• Draft comment:
  Renaming the span attribute key from 'name' to 'operation.name' enhances clarity. Ensure this change is consistent with your telemetry naming conventions and downstream expectations.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment suggests ensuring consistency with naming conventions and downstream expectations, which is a form of asking the author to double-check their work. This violates the rule against asking the author to ensure behavior is intended or to double-check things.

2. internal/telemetry/helpers.go:65

• Draft comment:
  The comment for the WithNewRoot function still refers to 'WithForceNewTrace', which is inconsistent with the function name. Please update the comment to match the function name.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. internal/telemetry/helpers.go:712

• Draft comment:
  In GetDefaultServiceSpanAttributes, the user ID attribute is set using "user_id" instead of the constant value "user.id" (as defined in SpanTagUserId). Consider using the constant or updating the string for consistency.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_CyQJN4MfrL04lSJ6

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}