Reclassify first instrument in MusicXML import#1056
Merged
mscuthbert merged 5 commits intoAug 8, 2021
Conversation
Rely on the MIDI program
mscuthbert
requested changes
Jul 24, 2021
Member
mscuthbert
left a comment
There was a problem hiding this comment.
One-staff pianos are unlikely to be correct -- need to look at instrument name a bit more to get more plausible instruments.
jacobtylerwalls
commented
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reclassify first instrument of part in MusicXML import
Previously
Previously, every first instrument was imported as an
instrument.Instrument. The test updated here to check for oboe, clarinet, and horn instruments fails on master.Now
Rely on the MIDI program rather than, say, a fromString() operation on the name, although this could be added later (for instance to change Piano to Soprano when a file used piano sounds rather than Choir Aahs).
Fixes #988
Future
import all instruments from part