Small changes from StreamStatus improvements#1870
Merged
mscuthbert merged 7 commits intomasterfrom Apr 17, 2026
Merged
Conversation
…improvements The streamStatusParent mechanism for skipping redundant makeBeams/makeAccidentals calls is fundamentally broken without a corresponding invalidation signal when stream elements change. Specifically, the per-measure `if m.streamStatus.beams: continue` guard left stale orphaned beams on notes after offbeat notes were removed, causing incorrect XML output. The incorrectly-anticipated self.e English braille assertion was also removed. Kept: bool type annotations, return None for inPlace paths, <supports> elements in MusicXML encoding, type annotations on makeBeams params, improved testMakeBeams coverage, testStreamExceptions measure fix, write-only property comments in braille tests, inPlace=False style in test_example15_11, and the fromStream else-branch bugfix (was returning unprocessed st instead of st2). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
coverage: 93.063% (+0.001%) from 93.062% — braille_updates into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed attempt at making StreamStatus allow the skipping of makeBeams (requested on music21list and elsewhere) -- some salvaged improved testing etc.
Add musicxml supports:
regularize order of attributes for musicXML getSupport() (backwards incompatible)
More tests.