Remove unnecessary sorts in graph/primitives.py#1872
Merged
mscuthbert merged 2 commits intomasterfrom Apr 20, 2026
Merged
Conversation
Replace sort-then-index-for-min/max patterns with direct min/max calls, and merge a redundant second loop in GraphScatter.renderSubplot into the first. No behavior change; O(n) instead of O(n log n). - Graph3DBars.renderSubplot: replace yDict + sort with single linear pass - GraphScatter.renderSubplot: drop xValues/yValues sorts, merge loops, use min/max directly (removes stale comment) - setIntegerTicksFromData: drop tickList.sort() (range() is already ascending) AI-assisted: Claude Sonnet 4.6 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
coverage: 93.072% (-0.001%) from 93.073% — claude/vibrant-keller-64c8ab into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were places where we were sorting data where we only needed max and min.
Graph3DBars.renderSubplot: replacedyDict+ O(n log n) sort with a single linear pass collecting x/y/z values, thenmin/maxGraphScatter.renderSubplot: droppedxValues/yValuessorts and redundant second loop; usemin/maxdirectly (removed stale comment)setIntegerTicksFromData: removedtickList.sort()—range()already produces ascending valuesNo behavior change; O(n) instead of O(n log n) in all three cases.
AI-assisted