Suppress spurious tuplet bracket on between-note tremolo round-trip.#1908
Closed
leahchilders wants to merge 2 commits into
Closed
Suppress spurious tuplet bracket on between-note tremolo round-trip.#1908leahchilders wants to merge 2 commits into
leahchilders wants to merge 2 commits into
Conversation
A time-modification with no matching tuplet was importing with a visible tuplet bracket and number, which has been fixed by setting the bracket and number not to show. Fixes cuthbertLab#1907
|
coverage: 93.05% (+0.001%) from 93.049% — leahchilders:fix-tremolo-tuplet-bracket into cuthbertLab:master |
Member
|
Thanks for taking time, but PR rejected because no bug, see explanation in #1907 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A time-modification with no matching tuplet was importing with a visible tuplet bracket and number, which has been fixed by setting the bracket and number not to show Added a regression test
testTremoloImpliedTupleand confirmed via reconstructed musicxml and imported into music notation software to verify visual fix.Fixes #1907