Fix parsing MIDI from URL#1916
Merged
Merged
Conversation
parseURL assumed that the stream created a metadata object. MIDI Converter did not. Fixes #1914 ``` >>> from music21 import * >>> converter.parse('https://scrime-apps.labri.fr/gp-provider/file?path=midi/the_last_year.mid', format='midi') <music21.stream.Score 0x104035be0> ```
|
coverage: 93.055% (-0.002%) from 93.057% — stream-metadata-midi-url into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseURL assumed that the stream created a metadata object. MIDI Converter did not.
Fixes #1914
Also clean up metadata assignments in features.DataSet -- that one had no bugs, but now typecheckers can know that. And give a default value to Features.dimensions. (Yeah, probably should have "split into two PRs" but time=$ and I'm doing my own reviews)