Remove v11 deprecations, and update pending deprecations#1919
Merged
Conversation
Now that the tree is on 11.0.0b1, clear out everything that was marked for removal in v11 and turn on the deprecations slated to start warning in v11. Removed (were deprecated for removal in v11): - midi.translate.midiEventsToInstrument (use midiEventToInstrument) - stream.Stream.hasElement (use `el in stream`) - musicxml.xmlToM21.MeasureParser.identificationToMetadata (use addIdentificationToMetadata) - string input to MeasureParser.getStaffNumber Deprecations now active in v11: - stream.Stream.hasElementOfClass: decorated @deprecated('v11', 'v12') and reimplemented as bool(self.getElementsByClass(className)); internal callers in sites.py and variant.py tests updated to the new idiom. getElementsByClass docs gained guidance on bool()/if/s[Class] membership testing. - variant.addVariant's replacementDuration keyword and Variant._setReplacementDuration now emit Music21DeprecationWarning (reads stay silent; the getter cannot warn without spurious firing). Doc-only: - tree.fromStream: "to be DEPRECATED" retargeted from v11 to v12. AI-assisted (Claude)
|
Coverage is 93.071% — worktree-v11-deprecation into master. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed (were deprecated for removal in v11)
midi.translate.midiEventsToInstrument— usemidiEventToInstrumentstream.Stream.hasElement— useel in streammusicxml.xmlToM21.MeasureParser.identificationToMetadata— useaddIdentificationToMetadataMeasureParser.getStaffNumber(the lazyint(str)coercion)Deprecations now active in v11
stream.Stream.hasElementOfClass— useif self.getElementsByClass(className):variant.addVariant'sreplacementDurationkeyword andVariant._setReplacementDurationAI-assisted (Claude)