[Feature]: Error handling UX for Lobby#1292
Merged
itsalaidbacklife merged 13 commits intocuttle-cards:mainfrom Nov 23, 2025
Merged
[Feature]: Error handling UX for Lobby#1292itsalaidbacklife merged 13 commits intocuttle-cards:mainfrom
itsalaidbacklife merged 13 commits intocuttle-cards:mainfrom
Conversation
Contributor
itsalaidbacklife
left a comment
itsalaidbacklife
left a comment
There was a problem hiding this comment.
Nice work! Thank you for your contribution. Change requests are in the comments. Main point is an explanation of why the snackbar was controlled by the store (to manage opening it from the socket event handlers)
Haviles04
added
the
version-patch
itsalaidbacklife
added
enhancement
itsalaidbacklife
approved these changes
Nov 23, 2025
Contributor
itsalaidbacklife
left a comment
itsalaidbacklife
left a comment
There was a problem hiding this comment.
Nice work; thank you for your contribution!
Contributor
|
Added #1299 to refactor snackbars into consolidated global component + store |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check the following
Please describe additional details for testing this change